Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline lexer plumbing and simplify error recovert wrt that #620

Merged

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Oct 24, 2023

Ref #608

Nothing ground-breaking but simplifies some of the machinery involved.

These are not needed until NomicFoundation#600 lands, so let's simplify the
implementation for now.
There's no benefit in bigger flexibility as these functions should
always be called using the lexer directly, so pass it directly in the
recovery code.
This makes the resulting code a bit easier to format and read, as it
doesn't need to group the parameter in `{}` and is better
supported/breaks easier in Rustfmt.
@Xanewok Xanewok requested a review from a team as a code owner October 24, 2023 15:00
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: 1b4e262

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Xanewok Xanewok added this pull request to the merge queue Oct 31, 2023
Merged via the queue into NomicFoundation:main with commit 18f590f Oct 31, 2023
1 check passed
@Xanewok Xanewok deleted the refactor-simplify-recovery-wrt-lexing branch October 31, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants